Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

qsv: fix 10b green frames #4876

Merged
merged 3 commits into from Jan 29, 2023
Merged

qsv: fix 10b green frames #4876

merged 3 commits into from Jan 29, 2023

Conversation

galinart
Copy link
Contributor

@galinart galinart commented Jan 26, 2023 •
edited

galinart and others added 3 commits January 26, 2023 14:24
@galinart
qsv: fix the clip range for user encoder buffer parameters
b44522c
@galinart @vsosunov
qsv: fix green frames for 10bit pipeline
1c153a7 
Fix the HandBrake#4842

Co-authored-by: Vladyslav Sosunovych <vladyslav.sosunovych@intel.com>
@galinart
WinGui: fix QSV constants for Windows GUI
ae68128 
After HandBrake@1847651 commit constants were changed.
Constants values must match the libhb/handbrake/common.h otherwise Windows GUI issues.
@galinart galinart added the Bug label Jan 26, 2023
@galinart galinart requested a review from sr55 January 26, 2023 16:28
@galinart galinart added this to the 1.6.2 milestone Jan 26, 2023
@galad87
Copy link
Contributor

galad87 commented Jan 26, 2023

Isn't there a way to import a C define in C# to avoid the same issue in the future?

@bradleysepos
Copy link
Contributor

We want to always encode 10-bit AV1, until we develop the ability to switch the output bit depth based on the input.

sr55
sr55 reviewed Jan 26, 2023
View reviewed changes
preset/preset_builtin.json Outdated Show resolved Hide resolved
@sr55
Copy link
Contributor

sr55 commented Jan 26, 2023

I should have some time at the weekend to validate and get this in.

@galinart
Copy link
Contributor Author

We want to always encode 10-bit AV1, until we develop the ability to switch the output bit depth based on the input.

Understood, the only thing that confused me that it is different that other presets do and name don't indicate this.

@sr55
Copy link
Contributor

sr55 commented Jan 26, 2023

Compatibility. Quite a few of the presets for HEVC or AV1 are now 10bit.

H264 10bit isn't the most compatible where as this is much less an issue for HEVC and I think almost a non issue for AV1

@bradleysepos
Copy link
Contributor

bradleysepos commented Jan 26, 2023 •
edited

HEVC and AV1 should be 10-bit for all presets and AVC 8-bit. Some hardware HEVC encoders I believe I left 8-bit because I could not QA them or they have known issues.

@sr55
Copy link
Contributor

sr55 commented Jan 29, 2023

Took a bit to figure out when this occurs but I re-created the bug and the fix appears to be good.

@sr55 sr55 merged commit c06a5eb into HandBrake:master Jan 29, 2023
sr55 pushed a commit that referenced this pull request Jan 29, 2023
@galinart @sr55
qsv: fix 10b green frames (#4876)
ba0ca93 
* qsv: fix the clip range for user encoder buffer parameters

* qsv: fix green frames for 10bit pipeline

Fix the #4842

Co-authored-by: Vladyslav Sosunovych <vladyslav.sosunovych@intel.com>

* WinGui: fix QSV constants for Windows GUI

After 1847651 commit constants were changed.
Constants values must match the libhb/handbrake/common.h otherwise Windows GUI issues.

---------

Co-authored-by: Vladyslav Sosunovych <vladyslav.sosunovych@intel.com>
(cherry picked from commit c06a5eb)
@sr55
Copy link
Contributor

sr55 commented Jan 29, 2023

Merged to 1.6.x branch for the 1.6.2 release.

@galad87 galad87 modified the milestones: 1.6.2, 1.7.0 Sep 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bradleysepos bradleysepos bradleysepos left review comments

@sr55 sr55 sr55 left review comments

Assignees
No one assigned
Labels
Bug
Milestone
1.7.0
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@galinart @galad87 @bradleysepos @sr55