Build system changes for BSD #5217
Conversation
|
I think @brad0 worked a bit on BSD compatibility too, they might want to take a look too. |
|
Everything looks fine on macOS too. |
|
LGTM as well. Thanks |
|
Although most looks Ok, a lot has little or nothing directly to do with *BSD. Like the changes for BeOS, POSIX threads, Python, POSIX compliancy for some scripts, etc. Typically I would split those up into smaller PRs. |
Rewrote repo-info.sh, tag-release.sh and build-presets.sh to remove the need for bash when compiling.
- Update python versions - Add libjpeg-turbo to modules to avoid conflict - Fix failure to make metainfo file
- The control characters for the colored text will only be used if the output is being sent to a terminal - Error messages have been consolidated into a single function
- Don't turn arguments of the form --arg=value into exports
Needed to detect failures in CI.
There needs to be only one space before the build number. Otherwise the shared library gets built without a version number.
It can be enabled on other operating systems with --enable-gtk
- Supported on Linux, FreeBSD, OpenBSD, NetBSD, and MinGW - Simplified support checks in configure.py
|
Looks good now. Approved.
I have to agree with @brad0 here (Brads united). This is a fairly large set of changes that I would prefer to be split into multiple PRs, but I also do not wish to stifle positive development this instance. Let's merge this and aim for smaller chunks in the future. Thanks @robxnano for the good work! |
|
@robxnano Thank you for the work. |
These changes are mostly to fix building on the different BSD variants, plus some changes to the build scripts to remove the bash requirement. As BSD and macOS don't have bash installed by default, it means one less program to install. I also added some colors to the configure script, which aren't strictly necessary but make the output a little easier to read. This change can be removed if you'd prefer to keep it as it is.
Tested on: