Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LinGui: GtkHeaderBar UI #5925

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

samhutchins
Copy link
Contributor

Most modern Gnome applications use a header bar which integrates the toolbar into the window's titlebar. HandBrake still uses the classic menubar, and I was curious about what a more modern approach might be like.

I thought I'd open a draft PR to see if this is something y'all are interested in, and to get some feedback

Before:
image

After:
image

I've been careful to maintain all the functionality that's found in the existing menu bar, by adding menu buttons to some of the toolbar buttons

image image image image

I appreciate that "more modern" doesn't necessarily mean "better" ;-)

 - Remove main menu bar, and move menus and their items to buttons in the HeaderBar
@galad87
Copy link
Contributor

galad87 commented Apr 6, 2024

That's definitely ugly imho 😆

@samhutchins
Copy link
Contributor Author

Ugly in a fundamental way, or ugly in a "it needs some styling" way?

@galad87
Copy link
Contributor

galad87 commented Apr 6, 2024

Not a fan of the unified toolbars, and the big NeXTSTEP style buttons don't help. Anyway, this it just my opinions, I don't have a say on the GTK UI 😜

@samhutchins
Copy link
Contributor Author

They don't have to be quite as big

image

@robxnano
Copy link
Contributor

robxnano commented Apr 6, 2024

My two cents: I'm not really a fan of this design either. It looks cluttered compared to most Gnome applications, which typically have only a few buttons on the headerbar and don't use as many labels. If you moved some of the less-used buttons to the overflow menu and shortened/removed some of the labels, it would look better, but at that point it might end up being less user-friendly than the previous layout.

But also I think you have to take into consideration the users of other desktop environments like Plasma or XFCE, for which this design would arguably be a downgrade. If we do decide to go through with this I think it would be a good idea to allow choosing between the traditional menu bar layout and the header bar one, similar to the approach taken by Evolution.

@samhutchins
Copy link
Contributor Author

That makes sense, I think I agree. I don't expect I'll take this much further to be honest, feel free to close :-)

@jstebbins
Copy link
Contributor

My $0.02. I really wish gnome had not gone in this direction. In some instances it's so cluttered it is unclear where you can grab the title bar in order to move the window. Nautilus file manager is an example of this. I keep hoping that it goes the same way as the experiment with putting the application menu in the screen hot-corner. Another bad idea since you often could not move the mouse to it without traversing another window and causing it to switch to another application.

If gnome persists with this design pattern, we may want to throw some token controls up there just to "fit in". But I don't think the primary workflow controls belong there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants