LinGui: add support for running a command after an encode completes #6029
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samhutchins
force-pushed
the
lin_gui_send_file_to
branch
from
2a24619
to
74bfa95
Compare
|
Looks good, but have you considered making this more useful in the Flatpak version? Users will probably expect the command to run outside the sandbox. You could do this by prepending |
|
I had not, I've never really used the flatpak version. Thanks for the pointers on where to start, I'll look into it |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change:
My lack of C and glib/gtk experience may very well be showing in full force here...
macOS and Windows can send the encoded file to an external application after the encode completes, this change adds that functionality for the Linux GUI as well. I'm not sure if this is the best way to invoke an external command
Tested on: