-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for AMD VCE Encoder. #88
Conversation
Resolving VCE changes with msater GUI Fix mkv output. Return error on bad profile level. Fix quality preset handling. WinGui: Fix bad resolved merge. libhb: Remove a block of code that was causing a crash. It doesn't seem to be needed. Both MKV and MP4 work without this.
Closing Pull Reject. The AMD Media Package has now been superseeded by a new SDK https://github.com/GPUOpen-LibrariesAndSDKs/AMF/ meaning this patch is no longer acceptable for HandBrake. Offical Line now is, If LibAV supports it, we can consider a simple patch that uses our current libav encoder wrapper but until then, we don't want any PR's that involve patching LibAV as it's too much effort for us to maintian. |
this is unfortunate.. a lot of folks have been waiting on this one to be merged :( |
It is but there is nothing we can do about it. As I said, we will be open to add it once upstream formally accept a patch. Right now, as far as I'm aware, no-one is working on one. It seems there just isn't a huge amount of interest in VCE. |
@sr55 There is only it is from people (like me) who are not used to check upstream drivers and libraries browse git etc they are average users that want to stream or upload youtube videos of their games or other stuff so they dont reach you... I for example trying for months to find a way to stream or atleast record my desktop with AMD VCE yet nothing is working... and I was so happy thinking that atleast handbrake had support for it but as it seems I misunderstood something because after installing handbrake (RX 580 8gb on ubuntu 17.10/4.15rc1/mesa17.4/LLVM6) I dont see the option for having AMD VCE as an encoder. |
Handbrake doesn’t support VCE yet. Maybe in the future. |
Core LibHB patch my Michael Wootton from AMD. Thanks
Windows UI updated by myself.