Fixes error binding context in layout #229
Conversation
| @@ -87,6 +87,10 @@ private object GetContextVariable(string variableName, object target) | |||
| { | |||
| object returnValue; | |||
| variableName = variableName.TrimStart('@'); | |||
| if (target.GetType() == typeof(HandlebarsCompiler.DynamicViewModel)) | |||
| { | |||
| target = ((HandlebarsCompiler.DynamicViewModel) target).Objects[1]; | |||
There was a problem hiding this comment.
This is concerning. I don’t understand how the 1nth position in the objects array is known to be the right value.
There was a problem hiding this comment.
At HandlebarsCompiler.cs line 64, it passes a DynamicViewModel instance with a argument object[] which the second object is the corresponding view model
There was a problem hiding this comment.
Positional significance is a code smell. If specific elements in the array have unique meaning, they should be made part of the model.
There was a problem hiding this comment.
You're right, it's a bad design and the whole #76 should be re-considered.
|
Going to avoid any additional investment in the baked-in view engine and focus on a better extensibility model in v2 that will afford well-designed view engines. |
No description provided.