UnencodedStatementVisitor resets value to previously #477
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
existing value when done.
oformaniuk
approved these changes
Dec 18, 2021
source/Handlebars/Compiler/Translation/Expression/UnencodedStatementVisitor.cs
Outdated
Show resolved
Hide resolved
Co-authored-by: Oleh Formaniuk <zjklee@gmail.com>
|
Kudos, SonarCloud Quality Gate passed! |
|
Thank you @zjklee for merging this fix. Will you release the patch sometime soon? 😄 |
|
@tonysneed , yes, I do plan to release a new version in a couple of days. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
existing value when done.
Fix #468 HandlebarsDotNet.Handlebars.Configuration.NoEscape Applied Inconsistently
Ref PR #473 [WIP] Configuration.NoEscape inconsistent fix
This PR does not deal with the question of general rules for encoding that was brought up in #473.