Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Growl Notification can not handle RTL Correctly, Inversed Images #799

Closed
AlBannaTechno opened this issue Apr 22, 2021 · 3 comments
Closed
Projects

Comments

@AlBannaTechno
Copy link

Hi,
I work on an RTL app, but I just noticed that the growl notification have an issue, might be two,
see,

2021-04-21_062015_2

The issue on the left side, Local Growl

     <hc:ScrollViewer
                Grid.Column="1"
                Grid.Row="0"
                Background="Transparent"
                VerticalScrollBarVisibility="Hidden" HorizontalAlignment="Right" IsInertiaEnabled="True"
                IsPenetrating="True">
                <StackPanel
                    hc:Growl.Token="AllMToken"
                    hc:Growl.GrowlParent="True" VerticalAlignment="Top" Margin="0,10,10,10" />
            </hc:ScrollViewer>

the alignment works correctly, but the image of states was inversed: this means that this image inherited the FlowDirection from its parent
which should not happen, it should explicitly be FlowDirection="LeftToRight"

The issue on the right side : Global Growl

Growl.ErrorGlobal() // and so on.

this seems to use LTR direction, so it produces a culture-specific alignment issue, view RTL language in LTR context
so the question here is, how to change the global Growl FlowDirection, if it is not possible, then it is an issue 😄

@ghost1372
Copy link
Member

@AlBannaTechno Thank you, I will send a PR to solve this problem soon

@ghost1372
Copy link
Member

if #801 accepted, you can use this code:

Growl.AskGlobal(new GrowlInfo
            {
                Message = "سلام خوش آمدید",
                FlowDirection = FlowDirection.RightToLeft,
                ActionBeforeClose = b =>
                {
                    if (!b) return true;
                    return true;
                }
            });

@ghost1372 ghost1372 added this to Todo in Roadmap May 24, 2021
NaBian added a commit that referenced this issue Jun 22, 2021
@NaBian
Copy link
Member

NaBian commented Jun 22, 2021

closed in 2fbcc1a

@NaBian NaBian closed this as completed Jun 22, 2021
Roadmap automation moved this from Todo to Done Jun 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Roadmap
  
Done
Development

No branches or pull requests

3 participants