You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Issue #1041 describes the reason they were marked as obsolete. I've quoted it below:
Neither of these methods works correctly, when the specified interval is not a multiple of the corresponding field's range length (max-min). For example, when we are using Cron.HourInterval(10), we will not get the documented every 10 hours semantic, instead we'll get the following occurrences:
Nov 6, 00:00
Nov 6, 10:00
Nov 6, 20:00
Nov 7, 00:00
Time interval between the last two entries is only 4 hours and violates what's written in the method's name and in its comments. Cron expressions don't allow to specify "every N" recurring intervals in general, and other methods should be used instead of confusing methods.
staviloglu
added a commit
to staviloglu/Hangfire
that referenced
this issue
Nov 24, 2022
Updated MinuteInterval & HourInterval methods to make them available (not obselete) again.
Added defensive code against interval value to get rid of the problem described in HangfireIO#1041
Also related:
HangfireIO#1054HangfireIO#1779
Why are the
MinuteInterval
,HourInterval
,DayInterval
andMonthInterval
functions considered Obsolete?In my opinion, it makes the code easier to read with
MinuteInterval(15)
instead of a string notation"*/15 * * * * "
.Of course I can copy these (or create similar) functions in my own project/library.
But is there a specific reason why they need to be removed from Hangfire.Core?
The text was updated successfully, but these errors were encountered: