Missing null-check on StorageConnection after casting it to JobStorageConnection

[burningice2866]

In the Retries-page of the dashboard, there is a missing Null-check, after casting the current connection to JobStorageConnection. This is a problem if one is using a JobStorage which doesn't implement JobStorageConnection but only IStorageConnection

https://github.com/HangfireIO/Hangfire/blob/master/src/Hangfire.Core/Dashboard/Pages/RetriesPage.cshtml#L21

[odinserj]

@burningice2866, got it! Would you like to make a PR and point it to the release-1.4.2 branch?

[burningice2866]

I'll look at it... can we assume that making an empty JobIds list and pager with 0 records will do the trick?

[odinserj]

I think we should show the message "Your storage currently does not support lalala and therefore we can't show this page" or so. Otherwise users may think retries aren't working, and ask a lot of questions on forum. On the other hand, if a pager shows this message for empty retries page (this is usual in normal circumstances), they will be sure retries aren't working. So, only null-check will work here, IMO.

[odinserj]

Hi @burningice2866, any news? I'm planning to release this bug fix in 1.4.2.

[odinserj]

Added the following message: