Improve DateTime resolution for job arguments #109
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
At job execution if a DateTime argument was included the DateTime object does not include milliseconds. The issue is caused at job creation when converting arguments to their string representation. The default conversion does not provide milliseconds. This is backwards compatible with existing data since a new DateTime object can be instantiated with both the old format and this new format, example: old: "05/30/2014 07:27:34" new: "05/30/2014 07:27:34.2791" If there is a better approach I'd be happy to make the change.
|
Thanks for contribution! Can you write unit test to cover this feature? |
|
Added unit test |
|
Please, add also a test, that checks |
…t names for clarity
|
Added additional test for deserialization of the new DateTime format. |
|
@dennyferra, thank you! |
odinserj
added a commit
that referenced
this pull request
Jun 1, 2014
Improve DateTime resolution for job arguments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At job execution if a DateTime argument was included the DateTime object does not include milliseconds. The issue is caused at job creation when converting arguments to their string representation. The default conversion does not provide milliseconds. This change is backwards compatible with existing data since a new DateTime object can be instantiated with both the previous format and this new format, example:
If there is a better approach I'd be happy to make the change.