Adding GetFirstByLowestScoreFromSet overload #1251
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Won't this break existing 3rd party storage connection implementations due to the new method on the interface? |
By introducing the new overload only in an abstract class, and making it virtual, we are removing breaking changes, making the implementation optional. So all the current storages will be compatible with these changes.
Just to use the same words as in other places like IMonitoringApi.
Since ArgumentException can be originated from different parameters, we also need to check the actual parameter that caused an exception.
The result is an ordered collection, and that order is based on `score` rather than on the value itself. Since HashSet can't preserve that type of ordering, we are using List instead.
|
Thanks @cdschneider for implementing this and writing tests! I've removed breaking changes as proposed by @burningice2866 (nice catch!) and did some cosmetic changes. Now waiting on CI results and merging it as soon as they are ready. I've also did some tests using this new method and rewritten |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First step in improving performance of
DelayedJobSchedulerbackground process, as mentioned in #38. This is also listed in the Hangfire 1.7.0 roadmap.The next step following this feature is to implement batch state transitions for the batch of retrieved jobs to be scheduled.