Add ability to automatically delete job when retry attempts exceeded #182
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Corrected this spelling mistake.
- Added an enum, ```AttemptsExceededAction``` - Added ```OnAttemptsExceededAction``` property - Added unit test to assert the ctor sets the correct default value
Extract method from ```OnStateElection```, to move the logic to schedule the job again for later into a seperate private method. This should make changing the main logic a little easier.
Fixes #104. When the retry attempt count exceedes the number of specified attempts, then the state should be transitioned to the ```DeletedState```. Added implementation and and unit tests to verify the new behaviour. - Added a test to verify that when the retry attempt count is exceeded and ```OnAttemptsExceeded``` is set to ```Delete``` then the state is transitioned to the ```DeletedState```. - Added a test to verify that when the retry attempt count is exceeded, and ```OnAttemptsExceeded``` is set to ```Fail``` then the default behaviour of setting the state to the ```FailedState``` is performed. - Added a test to verify that we can specify that no automatic retries should be performed, by setting ```Attempts``` to 0, and that we can have the job automatically be deleted.
|
@sgrassie, great job! I don't see any issues except tabs instead of spaces. Will merge after this fix. By the way, you can install http://editorconfig.org/ extension for Visual Studio to set options just for Hangfire automatically. |
Fix formatting issues - spaces, not tabs!
|
That is a handy little extension that I will definitely use in my own projects. Hopefully that should be the formatting issues taken care of. This will also mean than any future commits I make won't suffer from the same problem 👊 |
odinserj
added a commit
that referenced
this pull request
Aug 27, 2014
Add ability to automatically delete job when retry attempts exceeded
|
Great! I had the same problems when tried to work on Hangfire at my full-time job, and fully understand how it is difficult sometimes to switch between spaces/tabs. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated
AutomaticRetryAttributeto add the ability to automatically delete the job if the retry count is exceeded. The implementation is based off the discussion in #104.@odinserj I can see from the diff on github that the formatting is off somewhat. If you let me know what your tabs/spaces are set to, I'll fix it up and push an update onto the branch.
TODO: