Unmatched \end{environment} in \newcommand

[hippalectryon-0]

Type of JetBrains IDE (IntelliJ, PyCharm, etc.) and version

PyCharm 2023.1.2

Operating System

Ubuntu 22

TeXiFy IDEA version

0.7.30

What I did (steps to reproduce)

When creating a command that closes a block without opening it, the inspection raises an error (which in itself is understandable, as a warning at least), but this messes up the inspection of the blocks after the defined command.

Minimal example to reproduce the problem

In this example, the error is raised in the first command, and as a result subsequent commands fail to recognize their arguments

\newcommand{\closemulticol}[0]{  % Error "<key val key>, <required param content> or LatexTokenType.CLOSE_BRACE expected, got '\end'"
	\end{multicols}
}

\newcommand{\mycommand}[1]{#1}  % Warning "unescaped #"

Expected behavior

It's natural that a warning is raised in the command, as it's unusual that a command closes a block without opening it. However, it shouldn't mess up the inspection of subsequent commands.

[jojo2357]

Well IJ does the same thing if you have an extra } in java, so Im not sure there is anything to be done here, but ill let @PHPirates chime in

[PHPirates]

I know that this is perfectly valid LaTeX, but I'm not yet convinced that we should allow this. We can allow this in the parser, just like we do with e.g. \pretitle, but then of course you lose all (math) environment features like: indenting, environment rename, math highlighting (also inline math) and autocompletion. (That is, assuming we do want to keep a missing \end as a parse error. Maybe we can use a token remapper?)

@hippalectryon-0 could you give a use case for this, why you think this is good LaTeX style? In particular, why are you not using \newenvironment to define your own version of multicols?

[hippalectryon-0]

Our use case was a modifier that inserted an object in an existing table:

\newcommand{\tableMod}[0]{
	\end{multicols}
	\insertedObject
	\begin{multicols}{2}
}

[PHPirates]

That makes sense, thanks. I will see what we can do