Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not warn against missing non-breaking space before \citeauthor #912

Closed
marcotama opened this issue May 31, 2019 · 2 comments
Closed

Do not warn against missing non-breaking space before \citeauthor #912

marcotama opened this issue May 31, 2019 · 2 comments
Assignees
@HannahSchellekens
Labels
bug Deficiencies in TeXiFy behaviour. good-first-issue These issues are relatively simple and good to get yourself acquainted with the codebase.
Milestone
b0.6.6

Comments

@marcotama
Copy link

Hi, I am using PyCharm 2018.3.4 and TeXiFy IDEA 0.6.5.

I noticed that my usage of \citeauthor at the start of a sentence are marked in weak yellow (weak warning) because there is no non-breaking space before them. This makes sense with \cite, \citep etc. It would be great if the plugin realised that \citeauthor is part of a sentence and not a citation per se.
@PHPirates
Copy link
Collaborator

Agree, should be added to the list at https://github.com/Ruben-Sten/TeXiFy-IDEA/blob/c6d0d7f0db998a74cc63e363c3ee42bc538c4d6c/src/nl/rubensten/texifyidea/inspections/latex/LatexNonBreakingSpaceInspection.kt#L33

@PHPirates PHPirates added bug Deficiencies in TeXiFy behaviour. good-first-issue These issues are relatively simple and good to get yourself acquainted with the codebase. labels May 31, 2019
@HannahSchellekens HannahSchellekens self-assigned this Jun 13, 2019
@HannahSchellekens HannahSchellekens added this to the b0.6.6 milestone Jun 13, 2019
@HannahSchellekens
Copy link
Member

Easy fix, so fixed on master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@HannahSchellekens HannahSchellekens

Labels
bug Deficiencies in TeXiFy behaviour. good-first-issue These issues are relatively simple and good to get yourself acquainted with the codebase.
Projects
None yet
Milestone
b0.6.6
Development

No branches or pull requests
3 participants
@marcotama @PHPirates @HannahSchellekens