Added caching for referenced file sets #944
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
All usage was already delegated to the PsiFile.referencedFileSet extension method, so changing that method to use the ReferencedFileSetService was enough for it to take effect.
HannahSchellekens
added
the
enhancement
PHPirates
approved these changes
Jul 2, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added a caching mechanism for the infamous, relatively expensive
findReferencedFileSetfunction. The quick (1-2 min) tests I've conducted result in approximately 0.6 times a many file set calls: before95 msbetween each call on average, and after169 mstime between each call on average.Where the old mechanism keeps on calling the function a lot when you type, the new mechanism will signifiacntly lessen the amount of calls over time.
I have not yet tested this on larger scaled documents.
Additions
ReferencedFileSetCachethat handles the cache for file sets.ReferencedFileSetService(and impl) that act as accessor for the file set cache.Changes
PsiFile.referencedFileSetuse the said file set service.LatexCommandsImpl.subtreeChanged().