Use new JFace action factories

HannesWell · Jun 25, 2023 · eb89e98 · eb89e98
1 parent 9b89ec0
commit eb89e98
Show file tree

Hide file tree

Showing 2 changed files with 41 additions and 61 deletions.
diff --git a/...es/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/internal/progress/ProgressView.java b/...es/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/internal/progress/ProgressView.java
@@ -15,6 +15,7 @@
 package org.eclipse.ui.internal.progress;
 
 import org.eclipse.jface.action.Action;
+import org.eclipse.jface.action.IAction;
 import org.eclipse.jface.action.IMenuManager;
 import org.eclipse.jface.action.IToolBarManager;
 import org.eclipse.jface.action.MenuManager;
@@ -45,9 +46,9 @@ public class ProgressView extends ViewPart {
 
 	DetailedProgressViewer viewer;
 
-	Action cancelAction;
+	IAction cancelAction;
 
-	Action clearAllAction;
+	IAction clearAllAction;
 
 	private IPartListener2 partListener;
 
@@ -224,25 +225,15 @@ JobInfo getSelectedInfo() {
 	 * Create the cancel action for the receiver.
 	 */
 	private void createCancelAction() {
-		cancelAction = new Action(ProgressMessages.ProgressView_CancelAction) {
-			@Override
-			public void run() {
-				viewer.cancelSelection();
-			}
-		};
-
+		cancelAction = Action.create(ProgressMessages.ProgressView_CancelAction, () -> viewer.cancelSelection());
 	}
 
 	/**
 	 * Create the clear all action for the receiver.
 	 */
 	private void createClearAllAction() {
-		clearAllAction = new Action(ProgressMessages.ProgressView_ClearAllAction) {
-			@Override
-			public void run() {
-				FinishedJobs.getInstance().clearAll();
-			}
-		};
+		clearAllAction = Action.create(ProgressMessages.ProgressView_ClearAllAction,
+				() -> FinishedJobs.getInstance().clearAll());
 		clearAllAction.setToolTipText(ProgressMessages.NewProgressView_RemoveAllJobsToolTip);
 		ImageDescriptor id = WorkbenchImages.getWorkbenchImageDescriptor("/elcl16/progress_remall.png"); //$NON-NLS-1$
 		if (id != null) {

diff --git a/...les.undo/Eclipse UI Examples Undo/org/eclipse/ui/examples/undo/views/UndoHistoryView.java b/...les.undo/Eclipse UI Examples Undo/org/eclipse/ui/examples/undo/views/UndoHistoryView.java
@@ -25,6 +25,7 @@
 import org.eclipse.core.commands.operations.OperationHistoryEvent;
 import org.eclipse.core.commands.operations.OperationHistoryFactory;
 import org.eclipse.jface.action.Action;
+import org.eclipse.jface.action.IAction;
 import org.eclipse.jface.action.IMenuManager;
 import org.eclipse.jface.action.MenuManager;
 import org.eclipse.jface.action.Separator;
@@ -75,13 +76,13 @@ public class UndoHistoryView extends ViewPart implements
 		ISelectionChangedListener {
 	private TableViewer viewer;
 
-	private Action filterAction;
+	private IAction filterAction;
 
-	private Action doubleClickAction;
+	private IAction doubleClickAction;
 
-	private Action selectiveUndoAction;
+	private IAction selectiveUndoAction;
 
-	private Action refreshListAction;
+	private IAction refreshListAction;
 
 	private IOperationHistory history = OperationHistoryFactory
 			.getOperationHistory();
@@ -331,67 +332,55 @@ private void fillContextMenu(IMenuManager manager) {
 	 * Create the actions for the view.
 	 */
 	private void makeActions() {
-		filterAction = new Action() {
-			@Override
-			public void run() {
-				IUndoContext context = selectContext();
-				if (fContext != context && context != null) {
-					setContext(context);
-				}
+		filterAction = Action.create(() -> {
+			IUndoContext context = selectContext();
+			if (fContext != context && context != null) {
+				setContext(context);
 			}
-		};
+		});
 		filterAction.setText(UndoExampleMessages.UndoHistoryView_FilterText);
 		filterAction.setToolTipText(UndoExampleMessages.UndoHistoryView_FilterToolTipText);
 		filterAction.setImageDescriptor(PlatformUI.getWorkbench()
 				.getSharedImages().getImageDescriptor(
 						ISharedImages.IMG_OBJS_INFO_TSK));
 
-		selectiveUndoAction = new Action() {
-			@Override
-			public void run() {
-				IUndoableOperation operation = (IUndoableOperation) viewer.getStructuredSelection().getFirstElement();
-				if (operation.canUndo()) {
-					try {
-						history.undoOperation(operation, null, undoAction);
-					} catch (ExecutionException e) {
-						showMessage(UndoExampleMessages.UndoHistoryView_OperationException);
-					}
-				} else {
-					showMessage(UndoExampleMessages.UndoHistoryView_OperationInvalid);
+		selectiveUndoAction = Action.create(() -> {
+			IUndoableOperation operation = (IUndoableOperation) viewer.getStructuredSelection().getFirstElement();
+			if (operation.canUndo()) {
+				try {
+					history.undoOperation(operation, null, undoAction);
+				} catch (ExecutionException e) {
+					showMessage(UndoExampleMessages.UndoHistoryView_OperationException);
 				}
+			} else {
+				showMessage(UndoExampleMessages.UndoHistoryView_OperationInvalid);
 			}
-		};
+		});
 		selectiveUndoAction.setText(UndoExampleMessages.UndoHistoryView_UndoSelected);
 		selectiveUndoAction.setToolTipText(UndoExampleMessages.UndoHistoryView_UndoSelectedToolTipText);
 		selectiveUndoAction.setImageDescriptor(PlatformUI.getWorkbench()
 				.getSharedImages().getImageDescriptor(
 						ISharedImages.IMG_TOOL_UNDO));
 
-		refreshListAction = new Action() {
-			@Override
-			public void run() {
-				if (!viewer.getTable().isDisposed()) {
-					viewer.refresh(true);
-				}
+		refreshListAction = Action.create(() -> {
+			if (!viewer.getTable().isDisposed()) {
+				viewer.refresh(true);
 			}
-		};
+		});
 		refreshListAction.setText(UndoExampleMessages.UndoHistoryView_RefreshList);
 		refreshListAction.setToolTipText(UndoExampleMessages.UndoHistoryView_RefreshListToolTipText);
 
-		doubleClickAction = new Action() {
-			@Override
-			public void run() {
-				IUndoableOperation operation = (IUndoableOperation) viewer.getStructuredSelection().getFirstElement();
-				StringBuilder buf = new StringBuilder(operation.getLabel());
-				buf.append("\n");
-				buf.append("Enabled=");	//$NON-NLS-1$
-				buf.append(Boolean.toString(operation.canUndo()));
-				buf.append("\n");
-				buf.append(operation.getClass().toString());
-				showMessage(buf.toString());
-
-			}
-		};
+		doubleClickAction = Action.create(() -> {
+			IUndoableOperation operation = (IUndoableOperation) viewer.getStructuredSelection().getFirstElement();
+			StringBuilder buf = new StringBuilder(operation.getLabel());
+			buf.append("\n");
+			buf.append("Enabled="); //$NON-NLS-1$
+			buf.append(Boolean.toString(operation.canUndo()));
+			buf.append("\n");
+			buf.append(operation.getClass().toString());
+			showMessage(buf.toString());
+
+		});
 	}
 
 	/*