Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Meson-git breaks build #1770

Closed
ms178 opened this issue Nov 6, 2023 · 4 comments
Closed

Meson-git breaks build #1770

ms178 opened this issue Nov 6, 2023 · 4 comments

Comments

@ms178
Copy link

ms178 commented Nov 6, 2023

Usign meson-git (1.3.0rc1.r13.2d538c58c), the build now fails early on with:

vkd3d-proton/libs/d3d12core/meson.build:15:16: ERROR: shared_library keyword argument "objects" File: "d3d12core.def" are not objects

A full log can be found at /tmp/makepkg/vkd3d-proton-mingw-git/src/build/x64/meson-logs/meson-log.txt
WARNING: Running the setup command as `meson [options]` instead of `meson setup [options]` is ambiguous and deprecated.
@ionenwks
Copy link

For the record this should be fixed on meson's end (will be in upcoming >=1.3.0rc3) to emit a deprecation warning instead, see mesonbuild/meson#12508

Not that the warning shouldn't be fixed here either way to avoid future issues.

@HansKristian-Work
Copy link
Owner

The suggested fix to use vs_module_def breaks the build since MinGW targets ignore that apparently. We cannot fix this as-is.

@eli-schwartz
Copy link

I was a bit afraid of that but I didn't have the toolchain to build this locally.

It's a confusing situation since it was silently allowed for source files but not permitted for custom_target outputs... We really should be consistent and allow both. Well actually we should fix vs_module_defs to work correctly.

@eli-schwartz
Copy link

(I wish I'd known about this mingw failure mode a long time ago.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants