fix another regression in converting build_target kwargs to typed_kwargs #12508
Conversation
This time we have a case where people are passing non-objects by using them as str | File, which we never warned about and silently accepted. If it was passed via custom_target outputs we *would* error out, interestingly enough. At the backend layer, we just pass them directly to the linker... which is valid, if we misdetected what's a valid linker input or people just used funny names. In particular, the mingw toolchain allows passing a *.def file directly, and some people are doing that. If we do want to allow this, we should do it consistently. For now, just follow the current theme of what's expected, but do so by warning instead of fatally erroring, for cases where users were able to do it in the past.
Meson ignores vs_module_def when compiling against MinGW, and at least one known workaround is to use objects:. The docs suggests that using it with MinGW should work though. It mentions Windows, not MSVC in particular, but the name "vs_" does seem MSVC specific.
|
|
@HansKristian-Work That's a pretty serious bug for us, vs_module_defs should work for mingw. You're right about the name too. Do you know if there's an opened issue for that already, otherwise we need one. We should fix both that it doesn't work on MinGW, and update the documentation to specifically mention MinGW. |
|
Cross-posting my comments from the linked issue:
|
This time we have a case where people are passing non-objects by using them as str | File, which we never warned about and silently accepted. If it was passed via custom_target outputs we would error out, interestingly enough. At the backend layer, we just pass them directly to the linker... which is valid, if we misdetected what's a valid linker input or people just used funny names. In particular, the mingw toolchain allows passing a *.def file directly, and some people are doing that.
If we do want to allow this, we should do it consistently. For now, just follow the current theme of what's expected, but do so by warning instead of fatally erroring, for cases where users were able to do it in the past.