Implement a workaround for typed buffer view memory explosion #349
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HansKristian-Work
force-pushed
the
typed-buffer-offset
branch
5 times, most recently
from
bd81f95
to
62d43a5
Compare
This was referenced Oct 30, 2020
HansKristian-Work
force-pushed
the
typed-buffer-offset
branch
from
5c853c9
to
9f01ff7
Compare
|
We need to check for |
Signed-off-by: Hans-Kristian Arntzen <post@arntzen-software.no>
This will lead to a crash if it goes too far. Signed-off-by: Hans-Kristian Arntzen <post@arntzen-software.no>
We will use it for typed buffers as well. Signed-off-by: Hans-Kristian Arntzen <post@arntzen-software.no>
Signed-off-by: Hans-Kristian Arntzen <post@arntzen-software.no>
Signed-off-by: Hans-Kristian Arntzen <post@arntzen-software.no>
It is used for typed as well. Signed-off-by: Hans-Kristian Arntzen <post@arntzen-software.no>
HansKristian-Work
force-pushed
the
typed-buffer-offset
branch
from
9f01ff7
to
c98c29e
Compare
|
@doitsujin Fixed on AMD. Tested AMD/NV test suite, RE2, HZD, DS. Renders fine. |
doitsujin
reviewed
Nov 4, 2020
Signed-off-by: Hans-Kristian Arntzen <post@arntzen-software.no>
Signed-off-by: Hans-Kristian Arntzen <post@arntzen-software.no>
Signed-off-by: Hans-Kristian Arntzen <post@arntzen-software.no>
Signed-off-by: Hans-Kristian Arntzen <post@arntzen-software.no>
Offset buffer state might be the only relevant difference between two descriptors. We won't need to copy descriptors, but the offsets must be. Signed-off-by: Hans-Kristian Arntzen <post@arntzen-software.no>
Signed-off-by: Hans-Kristian Arntzen <post@arntzen-software.no>
Signed-off-by: Hans-Kristian Arntzen <post@arntzen-software.no>
Signed-off-by: Hans-Kristian Arntzen <post@arntzen-software.no>
Signed-off-by: Hans-Kristian Arntzen <post@arntzen-software.no>
Signed-off-by: Hans-Kristian Arntzen <post@arntzen-software.no>
Signed-off-by: Hans-Kristian Arntzen <post@arntzen-software.no>
Verifies that can we can spam unique typed views without problems ... Signed-off-by: Hans-Kristian Arntzen <post@arntzen-software.no>
HansKristian-Work
force-pushed
the
typed-buffer-offset
branch
from
c98c29e
to
7928164
Compare
doitsujin
approved these changes
Nov 4, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The overall idea is to bind typed views at aligned offsets and ranges, and rely on the offset buffer framework to make this work. This way we guarantee a reasonable upper bound for number of unique views that might exist per ID3D12Resource.
Fix #345.
Fixes this OOM condition on HZD and Death Stranding (and possibly others) on NVIDIA based on basic testing. There is no logging about ~1k views being created, where it would create at least 150k views before after a few minutes.