Add support for VK_VALVE_mutable_descriptor_type #375
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -754,6 +767,7 @@ static void vkd3d_physical_device_info_init(struct vkd3d_physical_device_info *i | |||
| VkPhysicalDeviceCustomBorderColorFeaturesEXT *custom_border_color_features; | |||
| VkPhysicalDeviceTimelineSemaphoreFeaturesKHR *timeline_semaphore_features; | |||
| VkPhysicalDevicePushDescriptorPropertiesKHR *push_descriptor_properties; | |||
| VkPhysicalDeviceMutableDescriptorTypeFeaturesVALVE *mutable_features; | |||
There was a problem hiding this comment.
funny christmastree ordering
HansKristian-Work
force-pushed
the
mutable-descriptor
branch
5 times, most recently
from
69ad463
to
3cbda66
Compare
HansKristian-Work
force-pushed
the
mutable-descriptor
branch
2 times, most recently
from
e5ff894
to
daab2cd
Compare
HansKristian-Work
force-pushed
the
mutable-descriptor
branch
3 times, most recently
from
3e6191d
to
5090298
Compare
HansKristian-Work
changed the title
|
Hi Hans, I can test this Vulkan, Mesa and vkd3d changes on my AMD Fury X (FIJI, GFX8). Are there some specific game titles to test this with that you would recommend? For testing correctness and performance compared to without it. |
doitsujin
requested changes
Dec 7, 2020
Signed-off-by: Hans-Kristian Arntzen <post@arntzen-software.no>
HansKristian-Work
force-pushed
the
mutable-descriptor
branch
from
8b6cdde
to
8517fc2
Compare
HansKristian-Work
force-pushed
the
mutable-descriptor
branch
2 times, most recently
from
3638f1a
to
4428ecd
Compare
doitsujin
reviewed
Dec 7, 2020
Signed-off-by: Hans-Kristian Arntzen <post@arntzen-software.no>
Signed-off-by: Hans-Kristian Arntzen <post@arntzen-software.no>
HansKristian-Work
force-pushed
the
mutable-descriptor
branch
from
4428ecd
to
06cc8b2
Compare
doitsujin
approved these changes
Dec 7, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RADV MR: https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/7967