vkd3d: reject creating a resource that is placed if the heap is too s… #702
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HansKristian-Work
requested changes
Jun 17, 2021
…mall The spec is pretty clear that it's invalid usage. Return E_INVALIDARG like native drivers. This is a workaround for the inventory GPU hang with Cyberpunk 2077 which is actually a game bug. Luckily the game handles this error properly. The problem is that the game always assume that an image with 2 mips is smaller than the same image but with 6 mips. This is not always true if the swizzle mode is different and a recent Mesa update changed that. Then the game creates a D3D12 heap that is too small and this triggered a memory violation and then a GPU hang with RADV. Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com>
HansKristian-Work
approved these changes
Jun 17, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a Cyberpunk 2077 game bug, again...