-
-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: Upgrade app to Nuxt 3 #253
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The timer page loads, but the layout transition doesn't work, there are invalid VNode types etc.
Note: the splash screen still does not disappear!
Note: it's still not working properly
This should indicate that the items are draggable
This gets rid of the warning that the plugin is using an old API
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces a huge refactoring of the app as the underlying engine is upgraded from Nuxt 2 to Nuxt 3. The most noteworthy changes (most of these are not user-facing):
The app is now managed using(this was reverted due to incompatibilities will full plug-and-play support and Netlify not supportingpnpm
instead ofyarn
. Please delete the previousnode_modules
folder, and reinstall usingpnpm install --shamefully-hoist
pnpm
, see chore(dev): Revert package manager to yarn #257)develop
branch: while the version inpackage.json
is still on1.2.0
the settings will reset on every page reload - this can be temporarily worked around by manually changing theversion
field inpackage.json
to1.3.0
. This issue will automatically go away when 1.3.0 is released.nuxt/pwa
) (due to incompatibilities), thenuxt/image
module and thenuxt/i18n
module.Phew.
Closes #248