Simplify create_new_parent_population in mu_plus_lambda
#170
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jakobj
changed the title
create_new_parent_population in mu_plus_lambda
mschmidt87
requested changes
Jul 2, 2020
|
Actually, it seems that without this PR, the tracking of lineage of individuals across the evolution made possible via #167 and #168 , would not be possible, because in the current implementation, we are cloning individuals to create a new parent population which would destroy the provenance tracking. Right? |
yes, this is true. of course only if we don't copy the idx in the |
jakobj
force-pushed
the
maint/refactor-create-new-parent-pop
branch
from
f1837ea
to
1348a3c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Seems like this function can be significantly simplified. I don't think there's a danger of sharing references, as each offspring is created via clone, which avoid specifically that.