Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Actually use to_torch in _test_to_torch #179

Merged
merged 1 commit into from
Jul 7, 2020
Merged

Actually use to_torch in _test_to_torch #179

merged 1 commit into from
Jul 7, 2020

Conversation

jakobj
Copy link
Member

@jakobj jakobj commented Jul 7, 2020

fixes #177

@jakobj jakobj added this to the 0.2.0 milestone Jul 7, 2020
@jakobj jakobj requested a review from mschmidt87 July 7, 2020 13:02
mschmidt87
mschmidt87 approved these changes Jul 7, 2020
View reviewed changes
Copy link
Member

@mschmidt87 mschmidt87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jakobj jakobj merged commit 66a8e5b into Happy-Algorithms-League:master Jul 7, 2020
@jakobj jakobj deleted the fix/test-to-torch branch July 7, 2020 13:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mschmidt87 mschmidt87 mschmidt87 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.2.0
Development

Successfully merging this pull request may close these issues.

_test_to_torch does not test torch, but numpy compilation of nodes
2 participants
@jakobj @mschmidt87