Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add setup.py to make library installable via pip #19

Merged
merged 4 commits into from
Mar 19, 2020
Merged

Conversation

mschmidt87
Copy link
Member

This PR adds a setup script to the repository so that the library can be installed via pip install . .
This fixes #7 .

@mschmidt87 mschmidt87 requested a review from jakobj March 17, 2020 05:47
Copy link
Member

@jakobj jakobj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks! 🎉 just some suggestions and a comment regarding dependencies

setup.py Outdated Show resolved Hide resolved
setup.py Show resolved Hide resolved
setup.py Outdated Show resolved Hide resolved
Maximilian and others added 2 commits March 18, 2020 20:57
Co-Authored-By: Jakob Jordan <1562742+jakobj@users.noreply.github.com>
Co-Authored-By: Jakob Jordan <1562742+jakobj@users.noreply.github.com>
Copy link
Member

@jakobj jakobj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i'm happy 👍 and merging

@jakobj jakobj merged commit 53560ee into master Mar 19, 2020
@jakobj jakobj deleted the pip_installation branch March 25, 2020 19:27
@mschmidt87 mschmidt87 added this to the 0.1.0 milestone Jun 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make pip installable
2 participants