Permissible values per gene in initialization of genome #201
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looking at the discussion in #158 i realized that |
mschmidt87
requested changes
Jul 27, 2020
jakobj
reviewed
Jul 27, 2020
There was a problem hiding this comment.
this looks great, nice work @HenrikMettler! 👌
i've added a few comments that should be addressed, mostly regarding style.
mschmidt87
requested changes
Jul 28, 2020
jakobj
requested changes
Jul 29, 2020
jakobj
reviewed
Jul 29, 2020
jakobj
approved these changes
Jul 29, 2020
Add new test for permissible gene values. Remove test for alternative_permissible_values since the functions were removed.
HenrikMettler
force-pushed
the
issue/perm_val_in_genome_init
branch
from
1971747
to
0995ec3
Compare
|
done @jakobj |
|
thanks! and merging :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Determine permissible values per gene in initialization of genome. Addresses #196.
I was not sure which of the
determine_permissible_value_xxxfunctions should be private. And please tell me whether you think testing with the permissible values for a single genome is sufficient.