Fix parameters being reininitialized in Genome.mutate() #213
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mschmidt87
approved these changes
Jul 30, 2020
|
my guess would be that the parent is maintained long enough to evolve such useful parameters that new offspring with reset parameters can not compete. as the parent is not mutated, local search will fit it's parameters correctly. |
As the mutate function uses the dna.setter it also triggers the function to initialize parameters. Before initializing any parameter it is now checked that it does have a value assigned yet. If it does, this parameter is not (re)initialized.
jakobj
force-pushed
the
fix/mutate-should-not-reinitialize-parameters
branch
from
99beba3
to
ce40c36
Compare
|
rebased, waiting for travis |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As
mutateusesdna.setterit also triggers the function to initialize numerical values for (unknown) parameters. Before initializing any parameter it is now checked that this does have a value assigned yet. If it does, this parameter is not (re)initialized.(ouch! 😬 )