-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Maint/isort #219
Maint/isort #219
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
so.much.tooling 🤤 🚀
thanks, this looks great! this has always bothered me, nice to see it's so easy to solve. added two meta comments.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good, thanks! 👍
before we merge, please squash the commits |
Add config file for isort
Thanks, I organized this now into 5 commits, which makes sense, in my opinion. Objections, @jakobj ? |
i'm happy! merging :) |
This PR introduces isort to our tools ensuring common coding standards and uniform layout across the library.
isort
sorts import statements in a particular, reproducible order, namely like this:FUTURE,STDLIB,THIRDPARTY,FIRSTPARTY,LOCALFOLDER
This PR:
isort
to all files in the library, testsuite, and examples. Therefore there are a lot of changes in many files, but they are just about formatting, mostly to the imports. Some changes are introduced byblack
as well (trailing commas in function definitions). I am not sure why this happens.isort
isort
to the requireddev
librariesisort
as an additional check to the CI.