Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Shorten execution of examples in CI #226

Merged
merged 1 commit into from
Aug 5, 2020
Merged

Shorten execution of examples in CI #226

merged 1 commit into from
Aug 5, 2020

Conversation

mschmidt87
Copy link
Member

@mschmidt87 mschmidt87 commented Aug 4, 2020 •
edited
Loading

This PR solves #208 by doing:

  • Add new mode for making docs with shortened example runs
  • Add class to set command line args in sphinx configuration
  • Shorten example runs in Travis CI and add docs building in deployment phase
  • Use specific commit of sphinx-gallery that includes the new option to specify CLI arguments (sphinx-gallery/sphinx-gallery@3879003)

@mschmidt87 mschmidt87 added the maintenance Fighting the second law label Aug 4, 2020
@mschmidt87 mschmidt87 requested a review from jakobj August 4, 2020 00:44
@mschmidt87 mschmidt87 force-pushed the CI/examples_short branch 3 times, most recently from a0d0f40 to 78d8a72 Compare August 4, 2020 04:25
@jakobj jakobj removed the maintenance Fighting the second law label Aug 4, 2020
@jakobj jakobj linked an issue Aug 4, 2020 that may be closed by this pull request
CI takes too long because of examples #208
Closed
@jakobj jakobj added this to the 0.2.0 milestone Aug 4, 2020
jakobj
jakobj approved these changes Aug 4, 2020
View reviewed changes
Copy link
Member

@jakobj jakobj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks, looks great 👍 please remember to remove the additional branch from CI again, otherwise, I'm happy :)

.travis.yml Outdated
@@ -9,6 +9,7 @@ env:
branches:
only:
- master
- CI/examples_short
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i assume this is just to test this PR, right?

@mschmidt87 mschmidt87 force-pushed the CI/examples_short branch 4 times, most recently from 8f3ccbb to 9b1ff68 Compare August 5, 2020 12:36
@mschmidt87
Shorten execution of examples in CI
5280cd2 
Add new mode for making docs with shortened example runs
Add class to set command line args in sphinx configuration
Shorten example runs in Travis CI and add docs building in deployment phase
Use specific commit of sphinx-gallery that support reset_argv conf arg
@mschmidt87 mschmidt87 merged commit 7932565 into master Aug 5, 2020
@mschmidt87 mschmidt87 deleted the CI/examples_short branch August 5, 2020 12:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jakobj jakobj jakobj approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.2.0
Development

Successfully merging this pull request may close these issues.

CI takes too long because of examples
2 participants
@mschmidt87 @jakobj