Bug-fix: Reorder changes phenotype for individuals with parameters (#261) #265
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
thanks for working on this @HenrikMettler! why did you remove the leading underscore of |
|
Sorry about that, I changed it during debugging, since assuming it had to be unprotected to replace the values. Reverted in the latest commit. |
jakobj
approved these changes
Jan 5, 2021
HenrikMettler
force-pushed
the
bug/reorder_parameters
branch
2 times, most recently
from
d7dba98
to
a4fb53d
Compare
HenrikMettler
force-pushed
the
bug/reorder_parameters
branch
from
a4fb53d
to
6dec7e9
Compare
|
excellent 👍 and merging |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the bug found in #261. Replaces the names in 'parameter_names_to_values' with the updated names (-> addresses).
The updated test currently fails after some reorderings - I can't understand why, help would be appreciated (I added some lines for debugging to make the error more understandable)