-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Redesign signatures of compilation targets #294
Redesign signatures of compilation targets #294
Conversation
I think this branch needs to be rebased on master to pull in the changes in the continuous integration and make the checks run. |
13c8362
to
fbf4c56
Compare
i rebased, thanks! ready for review :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just two minor formulations which might be improved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good in principle, thanks for doing this, looks like a tedious job. Added some suggestions.
thanks @mschmidt87 @HenrikMettler for your comments, i've included most of them. please have another look. |
d79e41e
to
f72523b
Compare
ok, simplified the code in question @mschmidt87 also squashed all commits, let's see what CI thinks |
This PR aims at making the usage of the results from various
to_...
functions more intuitive. It also improves their documentation. In the following the new usage is described in more detail.to_func
-> f:example usage:
to_numpy
-> f:example usage:
to_sympy
-> List[sympy expr] or single sympy exprcloses #287