Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Port CI from travis to github actions #296

Merged
merged 1 commit into from
Apr 4, 2021
Merged

Port CI from travis to github actions #296

merged 1 commit into from
Apr 4, 2021

Conversation

mschmidt87
Copy link
Member

@mschmidt87 mschmidt87 commented Mar 25, 2021 •
edited
Loading

This PR ports our Continuous Integration workflow from Travis CI to github actions:

  • Adds two files, one for the test suite, one for the publication of the documentation (only on pull-request merge)
  • Deletes the .travis configuration file
  • Deletes the deploy.sh script because I integrated this into the workflows file
  • Adds a config file for coveralls required by the github action managing coveralls.

The functionality of the CI itself does not change with this PR.

Note: Currently, we still require travis to pass in order to merge a PR. Once this PR is approved, I will deactivate this setting and then merge the PR. After that, I'll activate checks that the new workflow passes for all PRs.

Closes #266

@coveralls
Copy link
Collaborator

Coverage Status

Coverage remained the same at 94.41% when pulling 89b61b8 on ci/github_actions into 9e4689b on master.

@coveralls
Copy link
Collaborator

coveralls commented Mar 25, 2021 •
edited
Loading

Coverage Status

Coverage remained the same at 94.41% when pulling 62f8a49 on ci/github_actions into 9e4689b on master.

@mschmidt87 mschmidt87 force-pushed the ci/github_actions branch 9 times, most recently from 3d1e910 to 41ec8cb Compare March 25, 2021 08:21
@jakobj jakobj marked this pull request as draft March 25, 2021 10:29
@mschmidt87 mschmidt87 force-pushed the ci/github_actions branch 8 times, most recently from 35995ad to d28dfb8 Compare March 25, 2021 13:50
@mschmidt87 mschmidt87 marked this pull request as ready for review March 26, 2021 14:02
@jakobj jakobj added this to the 0.3.0 milestone Apr 3, 2021
jakobj
jakobj approved these changes Apr 3, 2021
View reviewed changes
Copy link
Member

@jakobj jakobj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks awesome, thanks for taking care of this! 🚀

one small question. and just one thing confuses me a bit: where do you configure what is run when? is this just set on the github interface?

.github/workflows/deploy_docs.yaml Outdated Show resolved Hide resolved
.github/workflows/tests.yaml Outdated Show resolved Hide resolved
@mschmidt87
Copy link
Member Author

one small question. and just one thing confuses me a bit: where do you configure what is run when? is this just set on the github interface?

I think by default github runs all workflows defined in .github/workflows/. Each of these workflows defines when it's run, in the on field of the yaml file.

@mschmidt87
Port CI from travis to github actions
3b00f3e 
Add workflows for github actions
Delete travis file
Add .coveragerc file for coveralls config
Remove deploy script for docs and include steps in github action directly
@mschmidt87 mschmidt87 merged commit afb3d0a into master Apr 4, 2021
@mschmidt87 mschmidt87 deleted the ci/github_actions branch April 4, 2021 13:46
@mschmidt87 mschmidt87 changed the title Add tests.yaml for github actions Port CI from travis to github actions Apr 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jakobj jakobj jakobj approved these changes

@HenrikMettler HenrikMettler Awaiting requested review from HenrikMettler

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.3.0
Development

Successfully merging this pull request may close these issues.

Switch from Travis CI to Github Actions
3 participants
@mschmidt87 @coveralls @jakobj