Add Cache specification #35
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good. 👍 Let's finish #34 before we merge this one. |
|
Cool, sounds good, I'll also add factory method for cache :) |
|
hehe great =) Because that is what our contribution file says =) |
|
Hehe, nice :) I'm on a train now so wifi is not good, so in worst case I'll update it when I'll be back in London :) |
|
@Nyholm updated :) |
| */ | ||
| public function modifyQuery(AbstractQuery $query) | ||
| { | ||
| $query->setResultCacheLifetime($this->cacheLifetime); |
There was a problem hiding this comment.
Did you leave out $this->parent->modifyQuery($query) intentionally?
There was a problem hiding this comment.
@Nyholm your question led me to some conclusions, will open a new issue.
|
please @cakper could you rebase? |
|
This is not blocked anymore (since merge of #56) |
|
all road blocks were taken off, ping. I think adding adding cache is complicating unnecessarily the library for now but ok. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Blocked by #39
@Nyholm I've prepared cache specification, basic one so far, but I think we may need to add options for Cache Profiles, Drivers etc.