Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removed create prefix #2

Merged
merged 1 commit into from Jul 24, 2019
Merged

Removed create prefix #2

merged 1 commit into from Jul 24, 2019

Conversation

aradoje
Copy link
Contributor

@aradoje aradoje commented Jul 24, 2019

This will fix #1

@Nyholm
Copy link
Member

Nyholm commented Jul 24, 2019

Ah, great. I just added PrettyC and itI is working. =)

@Nyholm Nyholm merged commit 3fc9a07 into master Jul 24, 2019
@Nyholm Nyholm deleted the remove-create-prefix branch July 24, 2019 12:42
@aradoje
Copy link
Contributor Author

aradoje commented Jul 24, 2019

Yea, It does not allow me to create dummy classes in tests :)

@Nyholm
Copy link
Member

Nyholm commented Jul 24, 2019

It does, no worries

@aradoje
Copy link
Contributor Author

aradoje commented Jul 24, 2019

I am refactoring it in the next PR. I don't like them in other namespace, if you are gonna make CI pass with them like that I will be happier :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove “create” prefix on Error class
2 participants
@aradoje @Nyholm