Add an event when a form button is clicked #79
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NiklasBr
reviewed
Nov 16, 2020
| @@ -37,7 +37,8 @@ document.addEventListener("DOMContentLoaded", function() { | |||
| xhr.open('POST', cookieConsentForm.action); | |||
| xhr.setRequestHeader('Content-Type', 'application/x-www-form-urlencoded'); | |||
| xhr.send(serializeForm(cookieConsentForm, event.target)); | |||
| // Clear all styles from body to prevent the white margin at the end of the page | |||
| location.reload(); | |||
| // Clear all styles from body to prevent the white margin at the end of the page | |||
There was a problem hiding this comment.
I believe this will prompt the user to re-submit any forms (if they have sent any POST data recently), which is not an optimal UX. I think window.location.href = window.location.href; should work. Also, the document styles below will become redundant because they will not happen.
There was a problem hiding this comment.
Good suggestion, I can use that in the event listener. For now it creates a custom event, instead of a forced refresh after a button click, so everyone can use another functionality if required. (see new commit)
maartenvanasperen
force-pushed
the
feature/reload-page-after-form-click
branch
from
1d99371
to
12d78f5
Compare
maartenvanasperen
force-pushed
the
feature/reload-page-after-form-click
branch
from
12d78f5
to
587abfe
Compare
| @@ -37,7 +37,13 @@ document.addEventListener("DOMContentLoaded", function() { | |||
| xhr.open('POST', cookieConsentForm.action); | |||
| xhr.setRequestHeader('Content-Type', 'application/x-www-form-urlencoded'); | |||
| xhr.send(serializeForm(cookieConsentForm, event.target)); | |||
| // Clear all styles from body to prevent the white margin at the end of the page | |||
|
|
|||
| let buttonEvent = new CustomEvent("cookie-consent-form-button-click", { | |||
There was a problem hiding this comment.
Suggested change
| let buttonEvent = new CustomEvent("cookie-consent-form-button-click", { | |
| let buttonEvent = new CustomEvent('cookie-consent-form-button-click', { |
| @@ -37,7 +37,13 @@ document.addEventListener("DOMContentLoaded", function() { | |||
| xhr.open('POST', cookieConsentForm.action); | |||
| xhr.setRequestHeader('Content-Type', 'application/x-www-form-urlencoded'); | |||
| xhr.send(serializeForm(cookieConsentForm, event.target)); | |||
| // Clear all styles from body to prevent the white margin at the end of the page | |||
|
|
|||
| let buttonEvent = new CustomEvent("cookie-consent-form-button-click", { | |||
There was a problem hiding this comment.
You could use var instead of let to keep it consistent with the other variables.
TimGroenenberg
approved these changes
Nov 17, 2020
maartenvanasperen
changed the title
maartenvanasperen
changed the title
matthijsch
approved these changes
Nov 17, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.