Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ADD: Widescreen Ocarina Effects #219

Merged
merged 5 commits into from
Apr 18, 2024

Conversation

PurpleHato
Copy link
Contributor

This adds the ocarina effects to scale properly from aspect ratio

BEFORE
image

AFTER:
image

Copy link

@MelonSpeedruns MelonSpeedruns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Contributor

@Archez Archez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 Glad to see a solution that scales with aspect ratio while retaining 4:3 original values

@louist103 louist103 merged commit ab76a84 into HarbourMasters:develop Apr 18, 2024
2 checks passed
@PurpleHato PurpleHato deleted the WidescreenOcarina branch April 18, 2024 01:25
garrettjoecox pushed a commit that referenced this pull request May 22, 2024
* ADD: Widescreen Ocarina Effect

* TWEAK: remove unecessary reassignment

* TWEAK: better assignments

* TWEAK: forgot some vanilla value
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants