Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

song from saria doesn't update on tracker after autosaving (with "any item" autosave enabled) #2147

Closed
briaguya-ai opened this issue Dec 11, 2022 · 9 comments
Assignees
Labels
bug Something isn't working

Comments

@briaguya-ai
Copy link
Contributor

briaguya-ai commented Dec 11, 2022

repro steps:

  • enable autosave
  • enable gAutosaveAllItems
  • open check tracker
  • play rando
  • get song from saria check
  • autosave happens
  • check tracker doesn't update
  • manually save
  • check tracker updates
@briaguya-ai briaguya-ai added the bug Something isn't working label Dec 11, 2022
@jbodner09 jbodner09 self-assigned this Dec 12, 2022
@jbodner09
Copy link
Contributor

I suspect there may be more like this from other actors, so I'll fix this one but also will need to do a 100% playthrough to make sure.

@briaguya-ai
Copy link
Contributor Author

I suspect there may be more like this from other actors, so I'll fix this one but also will need to do a 100% playthrough to make sure.

yeah, i made issues for the ones i noticed during my playthrough, i'm sure i didn't catch them all though

@jbodner09
Copy link
Contributor

jbodner09 commented Dec 14, 2022

@briaguya-ai do you remember the item you got from Saria? I'm playing through a rando right now, and when I got a song from her (I don't have songsanity turned on), it saved fine. Is it possible the item you got is just one that wouldn't have saved anyway?

On the other hand, I noticed that I'm not getting autosaves for major items that I'm getting from deku scrubs still (with scrubsanity turned on), so I'll need to look at that as well, since non-grotto scrubs should still save.

@jbodner09
Copy link
Contributor

jbodner09 commented Dec 14, 2022

And it IS saving after I pay the rupees to play a game like the bowling game and in grottos that I thought it shouldn't be. Hmm...

@briaguya-ai
Copy link
Contributor Author

do you remember the item you got from Saria?

checked my spoiler, it was epona's song (i also had songs shuffled to song locations) i might have gone there by playing minuet, i'll try to repro again tomorrow

@briaguya-ai
Copy link
Contributor Author

just tried to repro now on the build i played on, it seems it did autosave but the check tracker didn't update when it autosaved. after manually saving it did update

just tested on Bradley Bravo, same thing. I must have just missed the "game saved" notification when playing, seems this is actually a tracker issue, i'll update the description.

@briaguya-ai briaguya-ai changed the title song from saria doesn't count as "any item" for autosave song from saria doesn't update on tracker after autosaving (with "any item" autosave enabled) Dec 14, 2022
@jbodner09
Copy link
Contributor

Yeah, I've noticed the check tracker is taking quite a long time to update in a lot of places, although I do have performance mode turned on.

@briaguya-ai
Copy link
Contributor Author

Yeah, I've noticed the check tracker is taking quite a long time to update in a lot of places, although I do have performance mode turned on.

i found it worked best with performance mode off and autosave on all items, most checks update immediately after the autosave (my machine had no issues running that way)

@Rozelette
Copy link
Contributor

Probably fixed by rando v3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants