-
Notifications
You must be signed in to change notification settings - Fork 474
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Initial pass on some logging that would be helpful for debugging crashes/problems #1457
Initial pass on some logging that would be helpful for debugging crashes/problems #1457
Conversation
seems this may be able to tie in with some of the stuff we talked about in #1440 |
This opens a broader question of what to do with the authentic game's printfs. They give a ton of information, in japanese. This information would also be helpful in a crash situation. We can also translate to english in the code. Alternatively we can start with this PR using a new macro and only enable our prints and start a whole new log output. @briaguya-ai @dcvz which direction would you two prefer to go? |
@briaguya-ai do we want this or should we just close it in favor of eventual #1523 ? |
it depends, i think the idea is to include all of the authentic logs in addition to any logs we feel might be useful. this PR seems good as long as any overlap is handled gracefully |
2a25d4c
to
d9584ae
Compare
d9584ae
to
75ff8c8
Compare
3f1d237
to
5c70458
Compare
a310371
to
a5de5d4
Compare
8285f02
to
9578282
Compare
ec48847
to
b14bc9f
Compare
d44cdac
to
7e5fdf9
Compare
7e5fdf9
to
1577412
Compare
1577412
to
f7938c0
Compare
05bd4a3
to
ba13e6b
Compare
f0716d7
to
b035402
Compare
b035402
to
da790df
Compare
da790df
to
a708ea5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this has been open for a year, i say we merge it or close it (and i'm cool with merging it)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This actually looks really helpful, as especially when the crash is inside a draw call or something the information is often near useless on its own.
This is not meant to be an exhaustive amount of logging but just a simple starting point to provide more information for crashes and debugging.
Example log of creating & loading a save, walking over to Mido's house, opening the chests, saving and quitting.
Build Artifacts