implement audio backend fallbacks #1857
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
briaguya-ai
reviewed
Oct 26, 2022
louist103
reviewed
Oct 29, 2022
|
Hi @Alto1772, Also, I think the question about whether we want the fallback to be in LUS was just a question from bria.. I think we definitely do want to have that on the LUS side rather than SoH. |
|
now that we have libultraship pulled in as a submodule, you'll need to PR the libultraship side of things upstream to https://github.com/Kenix3/libultraship |
|
Reliant on: Kenix3/libultraship#28 |
briaguya-ai
force-pushed
the
develop
branch
2 times, most recently
from
05bd4a3
to
ba13e6b
Compare
briaguya-ai
approved these changes
Jan 19, 2023
briaguya-ai
requested changes
Jan 19, 2023
briaguya-ai
approved these changes
Jan 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As described in this comment: #1837 (comment)
This method does is if it fails to initialize at first, it loops and
Init()s through all available audio apis listed inaudioBackendsat libultraship/libultraship/ImGuiImpl.cpp until one returns successfully, and then overwriting the config file to use that one.also I've changed something inSeparated into as #1958GameMenuBar.cppthat fixes the zero entries in the the drop-down list so that it disables when there's only one entry.note: if u don't understand what i've just said here, just review my code, approve it or ask questions, or just don't.
Build Artifacts