Rando: Shuffle 100 Gold Skulltula Reward #1944
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…into hundred_spider_shuffle
briaguya-ai
added
the
merge conflicts
|
Looks like this is using a mismatched revision of libultraship. |
briaguya-ai
force-pushed
the
develop
branch
2 times, most recently
from
05bd4a3
to
ba13e6b
Compare
aMannus
removed
the
merge conflicts
briaguya-ai
reviewed
Jan 23, 2023
| hintTable[GANON_BK_SKULLTULA_HINT] = HintText::GanonsBossKey({ | ||
| // obscure text | ||
| Text { "And the %revil one%w's key will be&provided by the cursed rich man&once %r100 Gold Skulltula Tokens%w&are retrieved.", | ||
| /*french*/ HINT_TEXT_NEEDS_TRANSLATION_FR, |
There was a problem hiding this comment.
Thanks! PRed on their branch :)
lilDavid#6
| @@ -798,6 +798,15 @@ void GenerateItemPool() { | |||
| AddItemToMainPool(GOLD_SKULLTULA_TOKEN, 100); | |||
| } | |||
|
|
|||
| if (Shuffle100GSReward) { | |||
| if (ItemPoolValue.Is(ITEMPOOL_PLENTIFUL)) { | |||
| AddItemToPool(PendingJunkPool, GOLD_SKULLTULA_TOKEN, 10); | |||
There was a problem hiding this comment.
how does this work with tokensanity off? (i wouldn't expect many people to play with 100 skull reward and tokensanity off but it's possible)
There was a problem hiding this comment.
I completely forgot about tokensanity. I'll update this to check for it.
briaguya-ai
approved these changes
Jan 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After collecting all 100 Golden Skull Tokens, the cursed rich man in the House of Skulltula will give you a random item, and an extra Huge Rupee will be shuffled into the pool. The man will still give you Huge Rupees if you talk to him multiple times. Logic and an "always" hint are included.
Build Artifacts