Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: no longer leak memory, invalidate textures properly #2223

Merged
merged 6 commits into from
Dec 21, 2022
Merged

fix: no longer leak memory, invalidate textures properly #2223

merged 6 commits into from
Dec 21, 2022

Conversation

briaguya-ai
Copy link
Contributor

@briaguya-ai briaguya-ai commented Dec 21, 2022 •
edited

  • reverts Fix Ganondorf boss battle ending (MQ only) #2072
  • updates gSPInvalidateTexCache to use ResourceMgr_LoadTexOrDListByName to handle mq/nonmq texture logic
  • updates ganondorf to use ResourceMgr_LoadTexOrDListByName to handle mq/nonmq texture logic
  • updates king dodongo to only invalidate gDodongosCavernBossLavaFloorTex instead of everything

Build Artifacts

@leggettc18
Copy link
Contributor

Haven't investigated the memory leak yet, but can confirm the fix for the lava texture works and does not lag on Switch.

leggettc18
leggettc18 approved these changes Dec 21, 2022
View reviewed changes
Copy link
Contributor

@leggettc18 leggettc18 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed Ganondorf boss fight remains fixed and KD's lava floor texture changes without lagging on Switch.

@briaguya-ai
Copy link
Contributor Author

confirmed the memory leak is fixed by reverting 52b8962 (#2212 (comment))

@xoascf xoascf mentioned this pull request Dec 21, 2022
Closed
xoascf added a commit to xoascf/Shipwright that referenced this pull request Dec 21, 2022
@xoascf
Port some fixes from HarbourMasters#2223
4b864af
xoascf added a commit to xoascf/Shipwright that referenced this pull request Dec 21, 2022
@xoascf
Port some fixes from HarbourMasters#2223
515fdd3
@briaguya-ai briaguya-ai merged commit 73873a6 into HarbourMasters:develop-bradley Dec 21, 2022
@briaguya-ai briaguya-ai mentioned this pull request Dec 21, 2022
Closed
@briaguya-ai briaguya-ai deleted the fix-load-tex-by-name branch December 24, 2022 01:48
@xoascf xoascf mentioned this pull request Jan 9, 2023
Closed
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leggettc18 leggettc18 leggettc18 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@briaguya-ai @leggettc18