Tweak - Rando freestanding/skulltula ice trap behaviour #2230
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
briaguya-ai
force-pushed
the
develop
branch
2 times, most recently
from
05bd4a3
to
ba13e6b
Compare
briaguya-ai
approved these changes
Jan 19, 2023
briaguya-ai
added
the
merge conflicts
|
even github thinks this one has merge conflicts! (just need to update the cvar methods) overall this one is super exciting, let's resolve those conflicts and |
aMannus
added
merge ready
and removed
merge conflicts
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduces an actor freeze before the ice trap is triggered when a skulltula or freestanding ice trap is obtained.
For skulltulas, the ice trap only triggers after the textbox has been closed. Sadly, the function for freestanding items isn't called the same way as the skulltulas (it's only called once), so that one instead has a fixed freeze timer of 30.
Old skulltula behaviour:
https://user-images.githubusercontent.com/4244591/208966904-44a57e91-0e9e-43fa-929b-6a17fc89ede5.mp4
New skulltula behaviour:
https://user-images.githubusercontent.com/4244591/208966966-d628a6ea-26e5-4870-b9ed-2a92ced143ab.mp4
Old freestanding behaviour:
https://user-images.githubusercontent.com/4244591/208967023-c2a4f30d-a83b-4f41-ab65-44e12f55bc11.mp4
New freestanding behaviour:
https://user-images.githubusercontent.com/4244591/208967074-1c5f3706-60c6-4fa0-bbeb-e2b32fa4ed6c.mp4
Build Artifacts