chore: bump sdl version in appimage #2288
Conversation
|
tested the appimage and it's working for me |
| @@ -101,9 +101,9 @@ jobs: | |||
| - name: Install latest SDL | |||
| run: | | |||
There was a problem hiding this comment.
debatably tied to this scope: in order to make these upgrades easier in the future, we should probably add an env key to this step that specifies the SDL version.. so we only have to replace it once.
There was a problem hiding this comment.
Same could be done for SDL_net
There was a problem hiding this comment.
I feel like that may be overoptimizing a little, especially if the next release is going to be SDL3-..., the env var would need to be something like SDL_ARCHIVE_NAME, we'd need to set it to SDL2-2.26.1, and the wget URL/tar command would need to append .tar.gz
I'd feel better about it if we could have an env var and call it SDL_VERSION and set it to 2.26.1
Anyways, I'm not opposed to making the change, just noting that it feels less than perfect to me
There was a problem hiding this comment.
- name: Build SDL2
run: |
SDL2VER=2.26.1
export PATH="/usr/lib/ccache:/usr/local/opt/ccache/libexec:$PATH"
wget https://libsdl.org/release/SDL2-${SDL2VER}.tar.gz
tar -xzf SDL2-${SDL2VER}.tar.gz
cd SDL2-${SDL2VER}
./configure
make -j 10
sudo make install
sudo cp -av /lib/libSDL* /lib/x86_64-linux-gnu/
There was a problem hiding this comment.
@qurious-pixel the point is the next version will be sdl3, so sdl2ver won't work then
There was a problem hiding this comment.
Good point @briaguya-ai , let’s leave it like this for now. I think it’s still better to use a general version number even if the SDL2 will change but no hard preference
Co-authored-by: briaguya <briaguya@alice>
null
Build Artifacts