Map Select: Disable warning sound (BEL) sound by default #2306
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
would you mind splitting this up into 2 PRs? the warning sound fix should be able to be merged into bradley without any issues, but i feel like there's some discussion to be had around translating the loading messages |
xoascf
force-pushed
the
map-sel-tr-no-bell
branch
from
f7d67f5
to
1377a58
Compare
xoascf
changed the title
|
It was closed by mistake, it seems that GitHub fails to rename branches (using its own interface) and keep them in the PR. |
briaguya-ai
approved these changes
Jan 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Disabled by default the warning sound (BEL) in Map Select and others.
Build Artifacts