Fix: Entrance Rando one-way entrances preventing certain entrances from being overridden #2318
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A bug was preventing certain entrances from being overridden and missing from the spoiler log file when decoupled was off.
This would occur when a one-way entrance was early in the entrance sphere play through order (usually child/adult spawn). When decoupled is set to off, we avoid putting in the "coupled" entrance in the sphere order. This check was not accounting for one-way entrances, so if child spawn was set to a grotto exit, then the grotto itself would be missing from the entrance override list.
This fix makes it so we exclude one-way entrances from the coupled check.
As an aside, I think it may be best to modify the spoiler log for the actual entrance override IDs to not be derived from the play through sphere, that way if there is an error with the sphere itself in the log, it doesn't break the game. I'll reference this in #2308.
Prior to this fix I had 10+ bad seeds after generating 200 seeds. With this fix I confirmed after generating 500 seeds, that everything looks as expected.
Fixes #2275
Build Artifacts