Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rando: Adds 90~ new random rupee names, alphabetizes them #2330

Merged
merged 4 commits into from
Jan 21, 2023

Conversation

nianjiilical
Copy link
Contributor

@nianjiilical nianjiilical commented Jan 4, 2023

As the title says, massively expands the list of possible rupee names when Randomize Rupee Names is enabled. It's a fun and silly feature, so why not expand it? Also alphabetized the list because I was writing a lot anyway.

Most of the added names were taken by skimming a few currency or video game-related TVTropes pages for inspiration, picking ones that either come from popular works, sound funny, or both, plus a few little jokes.

First time contributing to the repo so I hope changing the text formatting slightly in the file doesn't ruin everything somehow, plus a few of them have umlats and characters that I think OoT supports but may be wrong on.

The list of new names added in case the people in charge want to approve them or just know the references:

new names
  • Bad RNG Rolls (joke)
  • Beanbean Coins (Mario & Luigi)
  • Beans (several things)
  • Beli (One Piece)
  • Berries (Bug Fables)
  • Bison Dollars (Street Fighter)
  • Blue Essence (League of Legends)
  • Bolts (Ratcher & Clank)
  • Boondollars (Homestuck)
  • BugFrags (Mega Man Battle Network)
  • Bǎn (Avatar The Last Airbender)
  • Chaos Orbs (Path of Exile)
  • Clams (a lot of things)
  • Cookies (Cookie Clicker)
  • Cor (Sword Art Online)
  • Crimebucks (Carmen Sandiego)
  • Crystal Shards (Kirby 64)
  • Cubits (Battlestar Galactica)
  • DNA (Spore)
  • Dalmations (Kingdom Hearts 2/101 Dalmations)
  • Dampecoin (ZFG's streams)
  • Dark Elixer (Clash of Clans)
  • Darseks (Star Trek)
  • Dead Memes (joke)
  • Dosh (Killing Floor)
  • Dwarfbucks (Dwarf Fortress)
  • Energon (Transformers)
  • Eris (Konosuba)
  • Eurodollars (Cyberpunk)
  • Extinction Points (Dino Crisis)
  • Flurbos (Rick and Morty)
  • Frog Coins (Super Mario RPG)
  • Gekz (Halo)
  • Gold Dragons (A Song of Ice and Fire)
  • Goober Dollars (Spongebob Squarepants)
  • Glitches (joke)
  • Green Herbs (Resident Evil)
  • Hell (Disgaea)
  • Hylian Loaches (OoT)
  • ISK (EVE Online)
  • Ice Traps (joke)
  • Kinstones (Zelda: Minish Cap)
  • Kremcoins (Donkey Kong Country 2)
  • Leaves (Octopath Traveller)
  • Lien (RWBY)
  • Lungmen Dollars (Arknights)
  • Macca (Shin Megami Tensei)
  • Mann Co. Keys (Team Fortress 2)
  • Meat (Kingdom of Loathing)
  • Meat Stacks (Kingdom of Loathing)
  • Medaparts (Medabots)
  • Monopoly Money (Monopoly)
  • Mora (Genshin Impact)
  • Mysteries (joke)
  • Neopoints (Neopets)
  • Nuyen (Shadowrun)
  • Pix (Recettear)
  • Pixels (Starbound)
  • Power Pellets (Pac-Man)
  • Primogems (Genshin Impact)
  • Refined Metal (Team Fortress 2)
  • Retweets (Twitter)
  • Rhinu (Discworld)
  • Riot Points (League of Legends)
  • Runite Ore (Runescape)
  • Ryō (Naruto)
  • Réals (Disco Elysium)
  • Saint Quartz (Fate/Grand Order)
  • Septims (Elder Scrolls)
  • Spent Casings (Enter the Gungeon)
  • Spice (Dune)
  • Spondulicks (Problem Sleuth)
  • Star Bits (Super Mario Galaxy)
  • Star Chips (Yugioh)
  • Stones of Jordan (Diablo 2)
  • Super Sea Snails (Splatoon)
  • Teef (Warhammer 40k)
  • Telecrystals (Space Station 13)
  • Tiberium (Command & Conquer)
  • TokKul (Runescape)
  • Turnips (Animal Crossing)
  • Upvotes (Reddit)
  • Watts (Pokemon Sword/Shield)
  • Widgets (Bionicle)
  • Woolongs (Cowboy Bebop)
  • World Dollars (Guilty Gear)
  • Wumpa Fruit (Crash Bandicoot)
  • [P] (Touhou)

Build Artifacts

Copy link
Contributor

@stratomaster64 stratomaster64 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So far so good! Just a few things regarding additions.

soh/soh/Enhancements/randomizer/randomizer.cpp Outdated Show resolved Hide resolved
soh/soh/Enhancements/randomizer/randomizer.cpp Outdated Show resolved Hide resolved
soh/soh/Enhancements/randomizer/randomizer.cpp Outdated Show resolved Hide resolved
soh/soh/Enhancements/randomizer/randomizer.cpp Outdated Show resolved Hide resolved
soh/soh/Enhancements/randomizer/randomizer.cpp Outdated Show resolved Hide resolved
@nianjiilical
Copy link
Contributor Author

nianjiilical commented Jan 21, 2023

Thanks for the feedback, I went ahead and made most of those changes. Replaced ????? and [404 ERROR] with Mysteries and Glitches to keep the theme, and renamed Runite Ore and Beli.

The only one I disagree with is Bison Dollars; it's obscure, but from what I've heard the movie is a cult classic and it's a pretty memorable part, to where it's gotten nods here and there officially. I think it's okay to have one or two more obscure picks in there, so hopefully that's fine.

Copy link
Contributor

@aMannus aMannus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall this is looking good! Always fun to have more names.

I've left 2 comments of my own.

Regarding Bison Dollars, I think it's fine to have some more obscure ones. Hell, Floopies is an imaginary currency me and a friend of mine used when we were little, lol. Not everyone is gonna get every single currency name, and that's fine in my eyes.

soh/soh/Enhancements/randomizer/randomizer.cpp Outdated Show resolved Hide resolved
soh/soh/Enhancements/randomizer/randomizer.cpp Outdated Show resolved Hide resolved
@nianjiilical
Copy link
Contributor Author

nianjiilical commented Jan 21, 2023

Unfortunately because I am very bad at code I haven't successfully managed to build SoH in the last hour or two, so I just cut Flobble Beans and Stones of Baranziah to be safe. Stones of Jordan and Extinction Points are at most one or two characters short of Canadian Dollars so they should fit fine?

Also cut Bullets re: above suggestion and added Kremcoins (Donkey Kong Country 2) and Medaparts (Medabots) because thats what I've been playing recently just to keep the number nice and round (also I removed Canadian Dollars by mistake apparently? whoops)

@briaguya-ai briaguya-ai merged commit a58705e into HarbourMasters:develop Jan 21, 2023
@nianjiilical nianjiilical deleted the rupeenames branch January 21, 2023 22:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants