-
Notifications
You must be signed in to change notification settings - Fork 466
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rando: Adds 90~ new random rupee names, alphabetizes them #2330
Conversation
05bd4a3
to
ba13e6b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So far so good! Just a few things regarding additions.
Thanks for the feedback, I went ahead and made most of those changes. Replaced ????? and [404 ERROR] with Mysteries and Glitches to keep the theme, and renamed Runite Ore and Beli. The only one I disagree with is Bison Dollars; it's obscure, but from what I've heard the movie is a cult classic and it's a pretty memorable part, to where it's gotten nods here and there officially. I think it's okay to have one or two more obscure picks in there, so hopefully that's fine. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall this is looking good! Always fun to have more names.
I've left 2 comments of my own.
Regarding Bison Dollars
, I think it's fine to have some more obscure ones. Hell, Floopies
is an imaginary currency me and a friend of mine used when we were little, lol. Not everyone is gonna get every single currency name, and that's fine in my eyes.
Unfortunately because I am very bad at code I haven't successfully managed to build SoH in the last hour or two, so I just cut Flobble Beans and Stones of Baranziah to be safe. Stones of Jordan and Extinction Points are at most one or two characters short of Canadian Dollars so they should fit fine? Also cut Bullets re: above suggestion and added Kremcoins (Donkey Kong Country 2) and Medaparts (Medabots) because thats what I've been playing recently just to keep the number nice and round (also I removed Canadian Dollars by mistake apparently? whoops) |
As the title says, massively expands the list of possible rupee names when Randomize Rupee Names is enabled. It's a fun and silly feature, so why not expand it? Also alphabetized the list because I was writing a lot anyway.
Most of the added names were taken by skimming a few currency or video game-related TVTropes pages for inspiration, picking ones that either come from popular works, sound funny, or both, plus a few little jokes.
First time contributing to the repo so I hope changing the text formatting slightly in the file doesn't ruin everything somehow, plus a few of them have umlats and characters that I think OoT supports but may be wrong on.
The list of new names added in case the people in charge want to approve them or just know the references:
new names
Build Artifacts