Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

workaround for vanilla save check tracker crash #2359

Merged
merged 1 commit into from
Jan 18, 2023
Merged

workaround for vanilla save check tracker crash #2359

merged 1 commit into from
Jan 18, 2023

Conversation

briaguya-ai
Copy link
Contributor

@briaguya-ai briaguya-ai commented Jan 18, 2023 •
edited by github-actions bot

fixes #2336

the true solution would be updating the tracker to fully support tracking vanilla saves, but that's way out of scope for this fix. this fixes the crash, nothing less, nothing more.

Build Artifacts

leggettc18
leggettc18 approved these changes Jan 18, 2023
View reviewed changes
Copy link
Contributor

@leggettc18 leggettc18 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Proper fix is that check tracker probably shouldn't use this or we need to add all the item entries but that's more of a feature than a fix, so this is fine as a band-aid fix.

@briaguya-ai briaguya-ai merged commit f665326 into HarbourMasters:develop-bradley Jan 18, 2023
@briaguya-ai briaguya-ai deleted the greg-to-the-rescue branch January 18, 2023 23:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Archez Archez Archez approved these changes

@leggettc18 leggettc18 leggettc18 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@briaguya-ai @Archez @leggettc18