Fix CC connection bugs #2367
Merged
Fix CC connection bugs #2367
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
briaguya-ai
reviewed
Jan 18, 2023
| @@ -101,7 +101,7 @@ void CrowdControl::Disable() { | |||
|
|
|||
| void CrowdControl::ListenToServer() { | |||
| while (isEnabled) { | |||
| while (!connected) { | |||
| while (!connected && isEnabled) { | |||
There was a problem hiding this comment.
why is this check being added here? shouldn't it be handled by the outer while loop?
There was a problem hiding this comment.
nevermind, i read this as if not while
There was a problem hiding this comment.
no, because this is an inner while that never reaches the outside while its in its own loop.. in this case a user might still disable CC before any connection is established, so we want to exit. Otherwise you get stuck in an infinite loop.
briaguya-ai
approved these changes
Jan 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2122
Fixes #2121
Thanks to @dcvz for making these fixes.
Build Artifacts