Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Full health spawn #2377

Merged
merged 3 commits into from
Jan 21, 2023
Merged

Full health spawn #2377

merged 3 commits into from
Jan 21, 2023

Conversation

briaguya-ai
Copy link
Contributor

@briaguya-ai briaguya-ai commented Jan 21, 2023 •
edited by github-actions bot

briaguya and others added 3 commits January 21, 2023 08:34
@MoriyaFaith
full health spawn
e497386 
Co-authored-by: MoriyaFaith <46070717+MoriyaFaith@users.noreply.github.com>
add enahancement to gamemenubar, update to use new cvar method names,…
db0bf28 
… simplify save loading logic so loading a save with less than 3 hearts spawns with full hearts with enhancement enabled instead of spawing with 3
formatting
82cd6c8
PurpleHato
PurpleHato approved these changes Jan 21, 2023
View reviewed changes
Copy link
Contributor

@PurpleHato PurpleHato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
We can wait on more feedback from the userbase if this will need to be included as a rando preset in the future

@briaguya-ai briaguya-ai merged commit a9e7faa into HarbourMasters:develop Jan 21, 2023
@briaguya-ai briaguya-ai deleted the full-health-spawn branch March 1, 2023 08:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Archez Archez Archez approved these changes

@PurpleHato PurpleHato PurpleHato approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@briaguya-ai @Archez @PurpleHato